Make metricsTracker implement Unwrap method. #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New https://pkg.go.dev/net/http#ResponseController introduced in Go 1.20 uses
Unwrap
method onhttp.ResponseWriter
implementations to get access to originalhttp.ResponseWriter
or underlying connection.This PR adds
Unwrap
method to*nethttp.metricsTracker
, which is a single implementation ofhttp.ResponseWriter
in this library. This makes it possible to use newhttp.ResponseController
with responses wrapped by this library.Note that
metricsTracker
implementation is based on httpsnoop, which now also supports Unwrap method: felixge/httpsnoop#8.