Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make metricsTracker implement Unwrap method. #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pstibrany
Copy link

New https://pkg.go.dev/net/http#ResponseController introduced in Go 1.20 uses Unwrap method on http.ResponseWriter implementations to get access to original http.ResponseWriter or underlying connection.

This PR adds Unwrap method to *nethttp.metricsTracker, which is a single implementation of http.ResponseWriter in this library. This makes it possible to use new http.ResponseController with responses wrapped by this library.

Note that metricsTracker implementation is based on httpsnoop, which now also supports Unwrap method: felixge/httpsnoop#8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant