Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Leonard Ehrenfried <[email protected]>
  • Loading branch information
t2gran and leonardehrenfried authored May 30, 2024
1 parent 3bbdd65 commit a511731
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/ext/java/org/opentripplanner/ext/flex/FlexRouter.java
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ private List<FlexServiceDate> createFlexServiceDates(
/**
* This class work as an adaptor around OTP services. This allows us to pass in this instance
* and not the implementations (graph, transitService, flexIndex). We can easily mock this in
* unit-tests. This also serves as documentation of witch services the flex access/egress
* unit-tests. This also serves as documentation of which services the flex access/egress
* generation logic needs.
*/
private class CallbackAdapter implements FlexAccessEgressCallbackAdapter {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import org.opentripplanner.transit.model.site.StopLocation;

/**
* Flex trips are not connected to the graph.
* Flex trips edges are not connected to the graph.
*/
public class FlexTripEdge extends Edge {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ private FlexAccessEgress createFlexAccessEgress(
) {
var flexEdge = getFlexEdge(flexVertex, transferStop);

// Drop none routable and very short(<10s) trips
// Drop non-routable and very short(<10s) trips
if (flexEdge == null || flexEdge.getTimeInSeconds() < MIN_FLEX_TRIP_DURATION_SECONDS) {
return null;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ public int findAlightIndex(StopLocation toStop) {
@Override
public FlexPathCalculator decorateFlexPathCalculator(FlexPathCalculator defaultCalculator) {
// Get the correct {@link FlexPathCalculator} depending on the {@code timePenalty}.
// Ff the modifier doesn't actually modify, we return the regular calculator.
// If the modifier doesn't actually modify, we return the regular calculator.
if (timePenalty.modifies()) {
return new TimePenaltyCalculator(defaultCalculator, timePenalty);
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public static GraphQLFieldDefinition create(
.name("dateTime")
.description(
"The date and time for the earliest time the user is willing to start the journey " +
"(if `false`or not set) or the latest acceptable time of arriving " +
"(if `false` or not set) or the latest acceptable time of arriving " +
"(`true`). Defaults to now"
)
.type(gqlUtil.dateTimeScalar)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public void withPreferences(Consumer<RoutingPreferences.Builder> body) {
/**
* The booking time is used to exclude services which are not bookable at the
* requested booking time. If a service is bookable at this time or later, the service
* is included. Currently, OTP only supports this for FLEX access and egress.
* is included. This apply to FLEX access, egress and direct services.
*/
public Instant bookingTime() {
return bookingTime;
Expand Down

0 comments on commit a511731

Please sign in to comment.