Fix filtering of inconsistent NeTEx stop times #5061
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the Graph Builder does not filter out NeTEx ServiceJourneys with inconsistent stop times.
In the current implementation, the stop times validation/filtering is performed in
org.opentripplanner.graph_builder.module.ValidateAndInterpolateStopTimesForEachTrip
for both GTFS and NeTEx imports, but in the NeTEx case the validation occurs too late, after the creation of TripTimes, preventing proper filtering.This PR moves the validation/filtering of stop times earlier in the import process so that incorrect trips are both reported and filtered out.
The filtering logic is also adapted to prevent filtering of valid flexible trips.
Issue
Unit tests
Added unit tests
Documentation
No