-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GBFS geofencing with VehicleRentalServiceDirectory #5324
Conversation
Please format your code. |
src/ext/java/org/opentripplanner/ext/vehiclerentalservicedirectory/api/NetworkParameters.java
Outdated
Show resolved
Hide resolved
...er/ext/vehiclerentalservicedirectory/api/VehicleRentalServiceDirectoryFetcherParameters.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've picked up on a few things.
bd349d0
to
6dbd916
Compare
6dbd916
to
0d629b0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5324 +/- ##
=============================================
+ Coverage 66.26% 66.55% +0.28%
- Complexity 15177 15288 +111
=============================================
Files 1789 1792 +3
Lines 69299 69455 +156
Branches 7354 7316 -38
=============================================
+ Hits 45924 46226 +302
+ Misses 20888 20752 -136
+ Partials 2487 2477 -10
☔ View full report in Codecov by Sentry. |
0d629b0
to
933a0fa
Compare
Co-authored-by: Leonard Ehrenfried <[email protected]>
Can you please regenerate the docs? |
...rg/opentripplanner/standalone/config/sandbox/VehicleRentalServiceDirectoryFetcherConfig.java
Outdated
Show resolved
Hide resolved
74c0617
to
732360c
Compare
732360c
to
0fa491f
Compare
...rg/opentripplanner/standalone/config/sandbox/VehicleRentalServiceDirectoryFetcherConfig.java
Outdated
Show resolved
Hide resolved
...rg/opentripplanner/standalone/config/sandbox/VehicleRentalServiceDirectoryFetcherConfig.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Leonard Ehrenfried <[email protected]>
0041ea9
to
eec2025
Compare
Summary
Unit tests
No
Documentation
The configuration documentation is added to the doc and moved from the router-config doc to VehicleRentalServiceDirectory sandbox doc.
Changelog
No
Bumping the serialization version id
No, only config is changed and that is stored in the serialized-graph as JSON.