Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GBFS geofencing with VehicleRentalServiceDirectory #5324

Merged
merged 14 commits into from
Oct 11, 2023

Conversation

t2gran
Copy link
Member

@t2gran t2gran commented Aug 28, 2023

Summary

  • Enable the use of GBFS geofencing zones with the VehicleRentalServiceDirectory.
  • Doc and code cleanup
  • In the previous version an error in the config would lead to a subset of the GBFS updaters to be stated. This is fixed, and all correct configured updaters are started, while updaters with mistakes or problems are logged with WARN level.
  • If geo-fencing is enabled, but there is no geo-fencing information available for a given GBFS network, then this is logged the first time the updater is run, but not more than once.

Unit tests

No

Documentation

The configuration documentation is added to the doc and moved from the router-config doc to VehicleRentalServiceDirectory sandbox doc.

Changelog

No

Bumping the serialization version id

No, only config is changed and that is stored in the serialized-graph as JSON.

@leonardehrenfried leonardehrenfried self-requested a review August 29, 2023 09:36
@leonardehrenfried
Copy link
Member

Please format your code.

Copy link
Member

@leonardehrenfried leonardehrenfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've picked up on a few things.

@t2gran t2gran added the Entur Test This is currently being tested at Entur label Aug 29, 2023
@t2gran t2gran force-pushed the otp2_gbfs_geofencing branch from bd349d0 to 6dbd916 Compare August 30, 2023 19:33
@t2gran t2gran marked this pull request as draft August 31, 2023 08:10
@t2gran t2gran force-pushed the otp2_gbfs_geofencing branch from 6dbd916 to 0d629b0 Compare August 31, 2023 11:58
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (2f1b266) 66.26% compared to head (eec2025) 66.55%.
Report is 342 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5324      +/-   ##
=============================================
+ Coverage      66.26%   66.55%   +0.28%     
- Complexity     15177    15288     +111     
=============================================
  Files           1789     1792       +3     
  Lines          69299    69455     +156     
  Branches        7354     7316      -38     
=============================================
+ Hits           45924    46226     +302     
+ Misses         20888    20752     -136     
+ Partials        2487     2477      -10     
Files Coverage Δ
...lanner/framework/logging/AbstractFilterLogger.java 1.71% <ø> (-2.29%) ⬇️
...ntripplanner/framework/logging/MaxCountLogger.java 66.66% <ø> (ø)
...rg/opentripplanner/framework/logging/Throttle.java 100.00% <100.00%> (ø)
.../org/opentripplanner/framework/time/TimeUtils.java 73.01% <100.00%> (+5.70%) ⬆️
...lanner/netex/loader/parser/ServiceFrameParser.java 73.97% <100.00%> (ø)
...ptor/rangeraptor/path/DestinationArrivalPaths.java 93.50% <100.00%> (+0.17%) ⬆️
...ox/VehicleRentalServiceDirectoryFetcherConfig.java 97.43% <100.00%> (+1.60%) ⬆️
...erentalservicedirectory/api/NetworkParameters.java 50.00% <50.00%> (ø)
...ehicleRentalServiceDirectoryFetcherParameters.java 61.11% <75.00%> (+3.96%) ⬆️
.../org/opentripplanner/framework/json/JsonUtils.java 83.33% <83.33%> (ø)
... and 4 more

... and 274 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t2gran t2gran force-pushed the otp2_gbfs_geofencing branch from 0d629b0 to 933a0fa Compare September 12, 2023 13:52
@t2gran t2gran modified the milestones: 2.4, 2.5 (next release) Sep 13, 2023
@t2gran t2gran marked this pull request as ready for review September 27, 2023 14:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Leonard Ehrenfried <[email protected]>
@leonardehrenfried
Copy link
Member

Can you please regenerate the docs?

@t2gran t2gran force-pushed the otp2_gbfs_geofencing branch from 74c0617 to 732360c Compare September 28, 2023 17:31
Co-authored-by: Leonard Ehrenfried <[email protected]>
@t2gran t2gran force-pushed the otp2_gbfs_geofencing branch from 0041ea9 to eec2025 Compare October 5, 2023 16:56
@t2gran t2gran merged commit 6d21145 into opentripplanner:dev-2.x Oct 11, 2023
5 checks passed
@t2gran t2gran deleted the otp2_gbfs_geofencing branch October 13, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants