Map GraphQL UnknowOperationException as bad request

[vpaturet]

Summary

When receiving a malformed GraphQL query that refers to an unexisting operation:

{"query":"{\n trip(\n from: {place: \"NSR:StopPlace:58189\"}\n to: {place: \"NSR:StopPlace:58287\"}\n numTripPatterns: 5\n ) {\n tripPatterns {\n duration\n legs {\n expectedStartTime\n expectedEndTime\n mode\n distance\n line {\n id\n publicCode\n }\n fromEstimatedCall {\n destinationDisplay {\n frontText\n }\n }\n fromPlace {\n name\n quay {\n publicCode\n }\n }\n toPlace {\n name\n quay {\n publicCode\n }\n }\n }\n }\n }\n}\n","variables":null,"operationName":"j"}

OTP logs an error message:

Unknown operation named 'j'.
graphql.execution.UnknownOperationException: Unknown operation named 'j'.
	at graphql.language.NodeUtil.getOperation(NodeUtil.java:84)
	at graphql.execution.Execution.execute(Execution.java:59)
	at graphql.GraphQL.execute(GraphQL.java:565)
	at graphql.GraphQL.lambda$parseValidateAndExecute$12(GraphQL.java:484)
	at java.base/java.util.concurrent.CompletableFuture.uniComposeStage(CompletableFuture.java:1187)
	at java.base/java.util.concurrent.CompletableFuture.thenCompose(CompletableFuture.java:2309)
	at graphql.GraphQL.parseValidateAndExecute(GraphQL.java:479)
	at graphql.GraphQL.executeAsync(GraphQL.java:438)
	at graphql.GraphQL.execute(GraphQL.java:365)
	at org.opentripplanner.ext.transmodelapi.TransmodelGraph.executeGraphQL(TransmodelGraph.java:65)
	at org.opentripplanner.ext.transmodelapi.TransmodelAPI.getGraphQL(TransmodelAPI.java:122)

and returns a GraphQL response with HTTP code 500:

{
    "errors": [
        {
            "message": "Unknown operation named 'j'.",
            "locations": [],
            "extensions": {
                "classification": "InternalServerError"
            }
        }
    ]
}

This PR ensures that the API returns an HTTP code 400 - Bad Request with the following GraphQL response:

{
    "errors": [
        {
            "message": "Unknown operation named 'j'.",
            "locations": [],
            "extensions": {
                "classification": "BadRequestError"
            }
        }
    ]
}

Issue

No

Unit tests

✅

Documentation

No

Changelog

No

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (36edab0) 66.38% compared to head (1d762a6) 66.39%.

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #5335      +/-   ##
=============================================
+ Coverage      66.38%   66.39%   +0.01%     
- Complexity     15176    15179       +3     
=============================================
  Files           1785     1785              
  Lines          69163    69163              
  Branches        7334     7334              
=============================================
+ Hits           45914    45922       +8     
+ Misses         20767    20758       -9     
- Partials        2482     2483       +1     

Files Changed	Coverage Δ
...tripplanner/ext/transmodelapi/TransmodelGraph.java	0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.