-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation for Service Journey filter #5641
Add implementation for Service Journey filter #5641
Conversation
faf6205
to
a42cf40
Compare
a42cf40
to
33a74fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good but I'm unsure of the performance impact of it.
Can you run a speed test with it? If you don't know how to do it, please get in touch.
@Bartosz-Kruba I removed the |
Closing this after conferring with @Bartosz-Kruba |
Summary
This PR adds implemnetation for the Service Journey input in the new filter API. Previously we did not had this functionality and the API was broken. No results were returned if user tried to perform a search with Service Journey as filter input.
Issue
N/A
Unit tests
Included new unit tests for the functionality
Documentation
N/A