Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overview and accessibility docs [ci skip] #5680

Merged
merged 4 commits into from
May 7, 2024

Conversation

abyrd
Copy link
Member

@abyrd abyrd commented Feb 10, 2024

This PR updates a couple of documentation pages for clarity.

The project overview page in the docs mentions OSM data first, followed by other formats without mentioning that they represent public transit service. This may be contributing to many first-time readers' impression that OTP is primarily intended or suited for bulk point-to-point street routing.

The modified text clearly states the purpose of public transit and bicycle sharing data sources. It also states that the data formats are open standards which has always been important to the project.

The update to the accessibility page is meant to anticipate questions and emails we've fielded over the years, from people confused (and possibly somewhat offended) by the use of "accessibility" to mean different things in different fields. Some people will land on the OTP documentation from web searches for the word "accessibility" intending multiple different meanings. This is also a first step toward providing clearer information on OTP's position on isochrone and travel time surface outputs. Links are provided to existing pages that touch on this subject. A final page on the subject will be added once that discussion is finalized.

@abyrd abyrd requested a review from a team as a code owner February 10, 2024 12:30
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.88%. Comparing base (aa92132) to head (6588a9f).

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5680      +/-   ##
=============================================
- Coverage      67.88%   67.88%   -0.01%     
+ Complexity     16559    16558       -1     
=============================================
  Files           1908     1908              
  Lines          72355    72355              
  Branches        7443     7443              
=============================================
- Hits           49120    49119       -1     
- Misses         20714    20715       +1     
  Partials        2521     2521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

currently limits implementation and discussion in this document to this binary
"wheelchair accessible" definition.

The term "accessibility" has a completely separate, unrelated definition in the fields of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is the intended audience for this explanation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The audience is people who search for "OTP accessibility" when looking for analysis uses and land on this page of the docs. People who are trying to understand the situation with travel time surfaces and isochrones, and ending up on the wrong page. It is indeed a bit out of place here.

The ideal would be to expand and revise the other page that is specifically about analysis uses. That other page will probably just redirect people to other tools (after giving them some background in case they're following up on past projects / articles). Then this page (on the more common meaning of accessibility) would only need a single sentence along the lines of "if you're looking for the other meaning of accessibility, see analysis page (link)".

So I'll just move this text over to the analysis page and suggest a short link here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update to the analysis docs page has long been on my mind since we talked about it in the past. But my sense in meetings is always that the fate/state of isochrone and one-to-many functionality is still being decided and I am not yet sure of those final decisions. But I think we can get this finalized soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entur have publicly stated that they want to remove it, but haven't actually done it.

@abyrd abyrd self-assigned this Feb 13, 2024
@abyrd abyrd marked this pull request as draft February 13, 2024 17:00
jtorin
jtorin previously approved these changes Feb 15, 2024
Copy link
Contributor

@jtorin jtorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text and the changes to looks good, can't vouch for the content and the strategy.

@abyrd abyrd marked this pull request as ready for review April 23, 2024 10:26
@abyrd abyrd changed the title Update overview and accessibility docs Update overview and accessibility docs [ci skip] May 6, 2024
@abyrd abyrd merged commit 4d038e5 into dev-2.x May 7, 2024
6 checks passed
@abyrd abyrd deleted the abyrd/access-overview-docs branch May 7, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants