Fix error in access filter when access with time-penalty exits

[t2gran]

Summary

A critical bug was introduced with the #5715. The effect of the bug was that all normal access was filtered out when an access with time-penalty existed. So, normal transit with walk access would dissapaer from the result. When setting the access mode to WALK the system would work as normal, only if an access with opening-hours exist would the walk access be filtered away.

Issue

This was discovered at Entur 2 days ago, and we have not created an issue for it.

Unit tests

✅ The unit tests are updated to cover this case.

Documentation

🟥 Not relevant

Changelog

🟥 This bug was introduced in 2.5-SNAPSHOT, so it does not exist in the last release of OTP; Hence, do not belong in the change log.

Bumping the serialization version id

🟥 The model is not changed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.77%. Comparing base (c82b91e) to head (87b2108).
Report is 2 commits behind head on dev-2.x.

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #5735   +/-   ##
==========================================
  Coverage      67.77%   67.77%           
  Complexity     16474    16474           
==========================================
  Files           1901     1901           
  Lines          72121    72121           
  Branches        7430     7430           
==========================================
+ Hits           48880    48882    +2     
+ Misses         20727    20726    -1     
+ Partials        2514     2513    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.