Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework clustering logic for sandbox geocoder #5879

Merged

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented May 29, 2024

Summary

OTP's geocoder is an important part of IBI's deployments and many customers like its specificity and customisability. During several rounds of feedback it was requested that the clustering feature be changed so that all elements in a cluster can be independently found. For this reason information that used to be hidden (primary, secondary elements) are now returned in the API.

This will allow the frontend components to build customised UIs for each customer.

⚠️ If you're a user of the cluster geocoding API, this is a breaking change!

cc @miles-grant-ibigroup

@leonardehrenfried leonardehrenfried added Sandbox IBI Developed by or important for IBI Group Skip Changelog labels May 29, 2024
@leonardehrenfried leonardehrenfried requested a review from a team as a code owner May 29, 2024 09:31
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 98.09524% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.49%. Comparing base (8f632f1) to head (6a73f01).
Report is 26 commits behind head on dev-2.x.

Files Patch % Lines
...pentripplanner/ext/geocoder/StopClusterMapper.java 96.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #5879      +/-   ##
=============================================
+ Coverage      68.47%   68.49%   +0.02%     
- Complexity     16698    16709      +11     
=============================================
  Files           1914     1916       +2     
  Lines          72673    72702      +29     
  Branches        7454     7449       -5     
=============================================
+ Hits           49763    49800      +37     
+ Misses         20340    20336       -4     
+ Partials        2570     2566       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a few minor tweaks. Code looks solid.

@leonardehrenfried leonardehrenfried merged commit 0695d7d into opentripplanner:dev-2.x Jun 3, 2024
5 checks passed
@leonardehrenfried leonardehrenfried deleted the cluster-geocoder branch June 4, 2024 21:11
@t2gran t2gran added this to the 2.6 (next release) milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IBI Developed by or important for IBI Group Sandbox Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants