-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework clustering logic for sandbox geocoder #5879
Rework clustering logic for sandbox geocoder #5879
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5879 +/- ##
=============================================
+ Coverage 68.47% 68.49% +0.02%
- Complexity 16698 16709 +11
=============================================
Files 1914 1916 +2
Lines 72673 72702 +29
Branches 7454 7449 -5
=============================================
+ Hits 49763 49800 +37
+ Misses 20340 20336 -4
+ Partials 2570 2566 -4 ☔ View full report in Codecov by Sentry. |
f9f5f49
to
78cd79b
Compare
src/main/java/org/opentripplanner/transit/model/site/StopLocationsGroup.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a few minor tweaks. Code looks solid.
Summary
OTP's geocoder is an important part of IBI's deployments and many customers like its specificity and customisability. During several rounds of feedback it was requested that the clustering feature be changed so that all elements in a cluster can be independently found. For this reason information that used to be hidden (primary, secondary elements) are now returned in the API.
This will allow the frontend components to build customised UIs for each customer.
cc @miles-grant-ibigroup