Add OTP request timeout GraphQL instrumentation #5881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The OTP request timeout feature provides a way to periodically check if the thread running an API request has been interrupted at a higher level (web server level).
This allows for cancelling long-running queries.
However this assumes that the running query will touch the code that checks for the interruption status.
While this works well for trip planning queries, other categories of query may never touch the check points.
This PR adds an extra level of protection by checking periodically the OTP request timeout status at the GraphQL level, while data is being fetched.
Issue
No.
Unit tests
No.
Documentation
No.