Update Google Pubsub updater configuration #5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5927 +/- ##
=============================================
+ Coverage 69.43% 69.45% +0.01%
Complexity 17065 17065
=============================================
Files 1934 1934
Lines 73606 73624 +18
Branches 7540 7539 -1
=============================================
+ Hits 51109 51135 +26
+ Misses 19870 19865 -5
+ Partials 2627 2624 -3 ☔ View full report in Codecov by Sentry. |
|
@leonardehrenfried is the docs build failing due to a recent dependency upgrade? |
|
Something like that: magidoc-org/magidoc#319 (comment) |
vpaturet
changed the title
vpaturet
added
Improvement
Sandbox
Real-Time Update
|
If you rebase the CI failure should be fixed. |
| c.of("fuzzyTripMatching").since(NA).summary("TODO").asBoolean(false) | ||
| c | ||
| .of("feedId") | ||
| .since(NA) |
There was a problem hiding this comment.
Can you add the version? The Google PubSub support was added in this PR: #3166
That would make it version 2.1.0.
leonardehrenfried
requested changes
Jun 25, 2024
vpaturet
force-pushed
the
update_google_pubsub_updater_doc
branch
from
70cb03e to
fc497ca
Compare
t2gran
approved these changes
Jun 25, 2024
leonardehrenfried
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
Removed parameters:
projectNameis deprecated and removed. It is replaced by the now-mandatory parameterstopicProjectNameandsubscriptionProjectNamepurgeExpiredDatais managed in the sectiontimetableUpdates. It does not need to be specified in this updater.typeis managed by the configuration framework. It does not need to be specified in this updater.Issue
No
Unit tests
Updated documentation test
Documentation
Updated documentation