-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fare service from Graph #6292
Draft
leonardehrenfried
wants to merge
8
commits into
opentripplanner:dev-2.x
Choose a base branch
from
leonardehrenfried:fares-refactoring
base: dev-2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove fare service from Graph #6292
leonardehrenfried
wants to merge
8
commits into
opentripplanner:dev-2.x
from
leonardehrenfried:fares-refactoring
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
added
Technical Debt
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
Skip Changelog
labels
Nov 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6292 +/- ##
=============================================
- Coverage 69.82% 69.81% -0.01%
+ Complexity 17827 17823 -4
=============================================
Files 2020 2020
Lines 76269 76269
Branches 7806 7806
=============================================
- Hits 53253 53248 -5
- Misses 20301 20305 +4
- Partials 2715 2716 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump serialization id
Add this label if you want the serialization id automatically bumped after merging the PR
Skip Changelog
Technical Debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes the fare service from the Graph instance and lets Dagger manage it instead.
Unit tests
A few unit tests had to be adjusted.
Bumping the serialization version id
✔️