Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Timetable#getTripTimes(index) #6506

Merged

Conversation

leonardehrenfried
Copy link
Member

Summary

This removes the methods Timetable#getTripTimes(index) and Timetable#getTripIndex. They provide an awkward API for getting TripTimes which is overly elaborate and unnecessary. These days these methods were mostly used for tests.

Unit tests

Updated.

Documentation

n/a

Changelog

Skip

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.20%. Comparing base (04fadbf) to head (7aab356).
Report is 13 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...dater/trip/gtfs/GtfsRealTimeTripUpdateAdapter.java 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6506   +/-   ##
==========================================
  Coverage      70.20%   70.20%           
+ Complexity     18313    18306    -7     
==========================================
  Files           2080     2080           
  Lines          77182    77161   -21     
  Branches        7831     7827    -4     
==========================================
- Hits           54183    54170   -13     
+ Misses         20230    20226    -4     
+ Partials        2769     2765    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

@leonardehrenfried leonardehrenfried merged commit a555e95 into opentripplanner:dev-2.x Mar 5, 2025
6 checks passed
@leonardehrenfried leonardehrenfried deleted the trip-index branch March 5, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants