-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Timetable#getTripTimes(index) #6506
Remove Timetable#getTripTimes(index) #6506
Conversation
0dea564
to
a410831
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6506 +/- ##
==========================================
Coverage 70.20% 70.20%
+ Complexity 18313 18306 -7
==========================================
Files 2080 2080
Lines 77182 77161 -21
Branches 7831 7827 -4
==========================================
- Hits 54183 54170 -13
+ Misses 20230 20226 -4
+ Partials 2769 2765 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change!
265c686
to
7aab356
Compare
Summary
This removes the methods
Timetable#getTripTimes(index)
andTimetable#getTripIndex
. They provide an awkward API for gettingTripTimes
which is overly elaborate and unnecessary. These days these methods were mostly used for tests.Unit tests
Updated.
Documentation
n/a
Changelog
Skip