Merge pull request #1022 from opentripplanner/app-menu-ext-links

fix(AppMenuItem): Make app menu external links open in new browser tab.
opentripplanner · Oct 6, 2023 · 0896680 · 0896680
2 parents 0537e10 + 72d84a3
commit 0896680
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/components/app/app-menu-item.tsx b/lib/components/app/app-menu-item.tsx
@@ -68,7 +68,9 @@ export default class AppMenuItem extends Component<Props, State> {
   render(): JSX.Element {
     const { icon, id, onClick, subItems, text, ...otherProps } = this.props
     const { isExpanded } = this.state
-    const Element = otherProps.href ? 'a' : 'button'
+    const hasHref = !!otherProps.href
+    const isAbsolute = otherProps.href?.startsWith('http')
+    const Element = hasHref ? 'a' : 'button'
     const containerId = `${id}-container`
     return (
       <>
@@ -80,6 +82,7 @@ export default class AppMenuItem extends Component<Props, State> {
           onClick={subItems ? this._toggleSubmenu : onClick}
           onKeyDown={this._handleKeyDown}
           {...otherProps}
+          target={hasHref && isAbsolute ? '_blank' : undefined}
         >
           <span aria-hidden>{icon}</span>
           <span>{text}</span>