Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unneeded word wrap for itin times. #1037

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Oct 17, 2023

Description

This PR removes some unneeded word wrap for leg times (those starting from 10 to 12am/pm in the itinerary body) and trip durations in the itinerary summary.

Closes #982, a duplicate

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@miles-grant-ibigroup
Copy link
Collaborator

Is this a duplicate of #982?

@binh-dam-ibigroup
Copy link
Collaborator Author

Is this a duplicate of #982?

A superset, but I did lose track of #982.

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the pr description to close the duplicated PR. Things all work

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, thank you!

@binh-dam-ibigroup binh-dam-ibigroup merged commit c3a143f into dev Oct 18, 2023
7 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the itinerary-style-fixes branch October 18, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants