Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Percy #1206

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Update Percy #1206

wants to merge 2 commits into from
+130 −91

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented May 2, 2024 •
edited
Loading

Description:
Our version of Percy was getting very old and it was causing problems

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this May 2, 2024
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review May 2, 2024 13:53
@daniel-heppner-ibigroup
Copy link
Contributor

Is this working? Why does Percy say no snapshots were uploaded?

@miles-grant-ibigroup
Copy link
Collaborator Author

Is this working? Why does Percy say no snapshots were uploaded?

Ugh oh...

@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as draft May 13, 2024 09:27
@miles-grant-ibigroup miles-grant-ibigroup added the WIP Work in progress label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @daniel-heppner-ibigroup @amy-corson-ibigroup