-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate find stop times for stop query #1290
Consolidate find stop times for stop query #1290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
looks like snapshots need to be cleaned up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seeing a bug. If I go to the schedule view for a stop, then click on a stop popup on the map, I see the weird "Loading Stop...".
We might need a new approach to getting these icons?
…ub.com/opentripplanner/otp-react-redux into consolidate-findStopTimesForStop-query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so confused how/why this works but it totally does! Yay
@@ -86,6 +86,8 @@ function getLayerName(overlay, config, intl) { | |||
return intl.formatMessage({ id: 'components.MapLayers.streets' }) | |||
case 'Satellite': | |||
return intl.formatMessage({ id: 'components.MapLayers.satellite' }) | |||
case 'Stops': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description:
Removes the shorter query for operators, as it was causing issues with the schedule in the nearby view.
PR Checklist: