Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support naming and keying transit vehicle overlay #1297

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Description:
Previously there was no way to name/key the transit vehicle overlay. This adds a new way to do that without needing any new explicit configuration types!

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just one suggestion

lib/components/map/default-map.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@amy-corson-ibigroup
Copy link
Contributor

Only thing is that percy is failing but I'm guessing you already noticed that!!

@miles-grant-ibigroup miles-grant-ibigroup merged commit bad8e44 into dev Nov 25, 2024
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the route-vehicles-overlay-name-override branch November 25, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants