-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trusted-companions): Plan trip with mobility profile for self or on behalf of trusted companion #1302
Conversation
…ty profile selector
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.7 to 6.6.0. - [Commits](indutny/elliptic@v6.5.7...v6.6.0) --- updated-dependencies: - dependency-name: elliptic dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
# Conflicts: # lib/components/user/types.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nitpicks but it seems to work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SO sorry for how long it took me to review this! Just a few cleanup things, but the bones look good!
@@ -111,13 +131,28 @@ const DtSelectorContainer = styled.div` | |||
} | |||
` | |||
|
|||
const MobilityProfileContainer = styled.div` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spacing and indenting here is looking really random. Can we
- Make the spacing even between d/t selector above and mode selector below (I think you can make this much higher, there's a lot of vertical space here you can use!)
- Make all the left-hand padding uniform and in line with the other elements around it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in fe2c134
…orm with surrounding elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Thank you for the changes
Description:
Allows a user to plan a trip according to a mobility profile for their self or on behalf of a trusted companion.
PR Checklist: