Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trusted-companions): Plan trip with mobility profile for self or on behalf of trusted companion #1302

Merged
merged 91 commits into from
Dec 10, 2024

Conversation

josh-willis-arcadis
Copy link
Contributor

Description:
Allows a user to plan a trip according to a mobility profile for their self or on behalf of a trusted companion.

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

josh-willis-arcadis and others added 30 commits October 23, 2024 14:16
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.7 to 6.6.0.
- [Commits](indutny/elliptic@v6.5.7...v6.6.0)

---
updated-dependencies:
- dependency-name: elliptic
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
# Conflicts:
#	lib/components/user/types.ts
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks but it seems to work!

lib/components/form/advanced-settings-panel.tsx Outdated Show resolved Hide resolved
lib/components/form/advanced-settings-panel.tsx Outdated Show resolved Hide resolved
lib/components/form/advanced-settings-panel.tsx Outdated Show resolved Hide resolved
lib/components/form/advanced-settings-panel.tsx Outdated Show resolved Hide resolved
i18n/en-US.yml Outdated Show resolved Hide resolved
i18n/en-US.yml Outdated Show resolved Hide resolved
@binh-dam-ibigroup binh-dam-ibigroup mentioned this pull request Nov 22, 2024
2 tasks
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO sorry for how long it took me to review this! Just a few cleanup things, but the bones look good!

@@ -111,13 +131,28 @@ const DtSelectorContainer = styled.div`
}
`

const MobilityProfileContainer = styled.div`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing and indenting here is looking really random. Can we

  1. Make the spacing even between d/t selector above and mode selector below (I think you can make this much higher, there's a lot of vertical space here you can use!)
  2. Make all the left-hand padding uniform and in line with the other elements around it
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in fe2c134

lib/components/form/advanced-settings-panel.tsx Outdated Show resolved Hide resolved
lib/components/form/advanced-settings-panel.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Thank you for the changes

@josh-willis-arcadis josh-willis-arcadis merged commit 7256079 into dev Dec 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants