Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(responsive-webapp): prevent error in safari positioning #1311

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Dec 2, 2024

Description:
Fix bug where current location was returning an error on mobile safari browsers. NOTE that this reverts #697. I tested for the bug outlined in that PR, and could not reproduce any issues. Could be related to a webkit update?

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna pass this. Just a note that I am not able to get the map centering to my current position on Safari for Mac, either on this branch or on the dev branch.

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amy-corson-ibigroup
Copy link
Contributor Author

amy-corson-ibigroup commented Dec 4, 2024

I am not able to get the map centering to my current position on Safari for Mac

This was technically a different issue, but thanks for catching it!! The GeolocateControl was returning a timeout error. I fixed this by adding enableHighAccuracy based on this: https://stackoverflow.com/questions/46689339/ionic-2-geolocation-timeout-error

The map current position button seems to be working for me now on all browsers. Added to this PR since it seems similar enough but let me know if you notice issues or want to see this split into a different PR @binh-dam-ibigroup @josh-willis-arcadis

@amy-corson-ibigroup amy-corson-ibigroup merged commit 5caf0b8 into dev Dec 6, 2024
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the fix-position-on-safari branch December 6, 2024 15:20
@amy-corson-ibigroup
Copy link
Contributor Author

The GeolocateControl was returning a timeout error. I fixed this by adding enableHighAccuracy

I nixed this because it wasn't behaving consistently! Opening a new PR to address this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants