-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(responsive-webapp): prevent error in safari positioning #1311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna pass this. Just a note that I am not able to get the map centering to my current position on Safari for Mac, either on this branch or on the dev branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was technically a different issue, but thanks for catching it!! The The map current position button seems to be working for me now on all browsers. Added to this PR since it seems similar enough but let me know if you notice issues or want to see this split into a different PR @binh-dam-ibigroup @josh-willis-arcadis |
I nixed this because it wasn't behaving consistently! Opening a new PR to address this issue |
Description:
Fix bug where current location was returning an error on mobile safari browsers. NOTE that this reverts #697. I tested for the bug outlined in that PR, and could not reproduce any issues. Could be related to a webkit update?
PR Checklist: