Nearby View: Add Location Field Search #1320
Conversation
| @@ -286,6 +306,32 @@ function NearbyView({ | |||
| > | |||
| {/* This is used to scroll to top */} | |||
| <div aria-hidden ref={firstItemRef} /> | |||
| <LocationField | |||
There was a problem hiding this comment.
you're missing a currentPosition prop here that's making it impossible to use current location
| @@ -139,6 +149,12 @@ function NearbyView({ | |||
| [nearbyViewCoords, currentPosition, map] | |||
| ) | |||
|
|
|||
| const reverseCoords = (coords) => { | |||
There was a problem hiding this comment.
Can we add a useEffect that checks if the currentPosition coords are the same as finalNearbyCoords and then runs reverseCoords? Right now if I use current location, there's no feedback that my location was picked up correctly
| ...nearbyViewCoords, | ||
| name: reversedPoint | ||
| }} | ||
| LocationIconComponent={() => ( |
There was a problem hiding this comment.
Hmm this isn't showing up on chrome or safari
There was a problem hiding this comment.
Also, when it does show up it feels v close to the placeholder text? Probably better suited to a OTP-UI PR, but I guess just flagging it here
| setReversedPoint(location.name || '') | ||
| }} | ||
| sortByDistance | ||
| /> | ||
| {loading && ( |
There was a problem hiding this comment.
Loading spinner is showing up on the location field which is a little misleading? Could we position it down to the results container
Adds a location field search field to the nearby view. There are still some styling concerns, and the current location issue is annoying as well. Would be nice to get that fixed.
Should we have it try to render a string on first load? If we did that then the placeholder text would never appear and that's why I'm against it.
Should we add using this thing to the Percy tests?