Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CallTaker Sliders to Dropdowns #971

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented Aug 10, 2023

Description:

The call taker custom advanced settings currently use walk sliders. This PR converts them into dropdown.

Blocked by opentripplanner/otp-ui#641

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Aug 10, 2023
@miles-grant-ibigroup miles-grant-ibigroup added BLOCKED Blocked (waiting on another PR to be merged) Call Taker/Field Trip Modules labels Aug 10, 2023
@miles-grant-ibigroup miles-grant-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Aug 23, 2023
@miles-grant-ibigroup
Copy link
Collaborator Author

No longer blocked @daniel-heppner-ibigroup

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly easy change! Thank you!

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miles-grant-ibigroup miles-grant-ibigroup merged commit b63feca into dev Aug 30, 2023
@miles-grant-ibigroup miles-grant-ibigroup deleted the call-taker-walk-reluctance-dropdwon branch August 30, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants