Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pattern viewer #985

Merged
merged 9 commits into from
Aug 31, 2023
Merged

Fix pattern viewer #985

merged 9 commits into from
Aug 31, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

This PR fixes

  • the pattern dropdown in the Patter Viewer, so that the correct name for the viewed pattern is always shown,
  • the stops list, so it can handle looped patterns.

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • [na] Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

miles-grant-ibigroup
miles-grant-ibigroup approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of good fixes here, thanks! Working great no regressions

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks for the fixes. I hope we can generate some types from the schema soon to eliminate all these types scattered around.

@binh-dam-ibigroup binh-dam-ibigroup merged commit be34ec6 into dev Aug 31, 2023
5 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-pattern-viewer branch August 31, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @miles-grant-ibigroup @daniel-heppner-ibigroup