Improve feedback when saving locations, add toast notifications #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r resending phone verif code.
binh-dam-ibigroup
changed the title
amy-corson-ibigroup
approved these changes
Sep 18, 2023
| @@ -138,7 +139,7 @@ export function convertToLegacyLocation(place) { | |||
| lon, | |||
| // HACK: If a place name and address are provided, put the address in parentheses | |||
| // to mimic the existing LocationField behavior for "work" and "home". | |||
| // TODO: use addInParentheses from location-field (requires passing an intl contexty). | |||
| // TODO: use addInParentheses from location-field (requires passing an intl context). | |||
AdrianaCeric
requested changes
Sep 20, 2023
i18n/en-US.yml
Outdated
| @@ -52,6 +52,8 @@ actions: | |||
| emailVerificationResent: The email verification message has been resent. | |||
| genericError: "An error was encountered: {err}" | |||
| itineraryExistenceCheckFailed: Error checking whether your selected trip is possible. | |||
| mustBeLoggedInToSavePlace: Please log in to save locations. | |||
| placeRemembered: "Your {placeType} has been set to: {address}." | |||
There was a problem hiding this comment.
placeType is either "custom" or "dining" which results in the alert becoming either:
- "Your custom has been set to: Sesame Street."
- "Your dining has been set to: Sesame Street."
Adding something like "place type" would help make this alert more clear
Suggested change
| placeRemembered: "Your {placeType} has been set to: {address}." | |
| placeRemembered: "Your {placeType} place type has been set to: {address}." |
There was a problem hiding this comment.
Good point! I changed the confirmation popup in e1c6453 so it shows the correct place name, and did away with showing the address as there can be other settings for places later.
AdrianaCeric
approved these changes
Sep 21, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the user feedback from setting the home or work locations, from the map and the places editor, notably with toast notifications or alerting logged out users they need to log in. Some other confirmation alert messages are also converted into toast notifications.
Under the hood, the added
react-hot-toastpackage improves the "politeness" of the confirmation messages shown.PR Checklist