Percy: mobile snapshots, separate key for calltaker, mock geocoder #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
changed the title
This reverts commit 56a230b.
miles-grant-ibigroup
approved these changes
Sep 14, 2023
| @@ -196,7 +218,8 @@ async function executeTest(page, isMobile, isCallTaker) { | |||
| ) | |||
| await page.waitForSelector('.intermediate-place-0-form-control') | |||
| await page.focus('.intermediate-place-0-form-control') | |||
| await page.keyboard.type('arts center') | |||
| // FIXME: Characters are typed very fast, but each stroke still triggers a geocoder call. | |||
There was a problem hiding this comment.
The call should be being aborted, but because the geocoder is at localhost the connection is established before it can be aborted.
| test('OTP-RR Mobile', async () => { | ||
| const page = await loadPath('/') | ||
| page.isMobile = true |
daniel-heppner-ibigroup
approved these changes
Sep 19, 2023
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the percy test so it runs and keeps the mobile snapshots, and uses a separate percy key for calltaker mode and runs calltaker snapshots in a separate job to avoid race conditions. Geocoder is mocked too now. Feedback welcome on how to reduce run time or reuse the checkout steps.
PR Checklist: