Remove OTP1 Stop Time Filtering #994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,11 +136,8 @@ export function getStopTimesByPattern(stopData) { | |||
| times: [] | |||
| } | |||
| } | |||
| // Exclude the last stop, as the stop viewer doesn't show arrival times to a terminus stop. | |||
| const filteredTimes = times.filter(excludeLastStop) | |||
There was a problem hiding this comment.
This change results in the display of arrival times (in addition to departures) at terminal stops. Per our discussion, this is not desired.
There was a problem hiding this comment.
I can't replicate this. Do you have any examples?
There was a problem hiding this comment.
Ok never mind I can see it on some bus routes where the last stop of one pattern is not identical to the first stop of another. Looking at the behavior I am not against that
binh-dam-ibigroup
requested changes
Sep 12, 2023
|
This will be addressed by the nearby view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When we switched to the new stop viewer, we forgot to remove a filter that was only relevant for the old stop viewer and OTP1. The result was no stop times appearing at the second to last stop! This PR removes this filter and fixes things.
PR Checklist: