-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer leg support #779
Transfer leg support #779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, wondering if we should really display the walk icon for transfer legs.
packages/itinerary-body/src/defaults/access-leg-description.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Heppner <[email protected]>
What icon are you looking for? |
Maybe... no icon? idk |
So the snapshots are making it seem like there's some weird stuff going on with TNC legs, but this seems to be a snapshot issue more than an actual issue (our data is funky/OTP1) |
Supports rendering "transfer" legs correctly. They are just informational, there's no directions that should be shown