Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer leg support #779

Merged

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Supports rendering "transfer" legs correctly. They are just informational, there's no directions that should be shown

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see minor comments.

packages/itinerary-body/i18n/fr.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, wondering if we should really display the walk icon for transfer legs.

Co-authored-by: Daniel Heppner <[email protected]>
@miles-grant-ibigroup
Copy link
Collaborator Author

What icon are you looking for?

@miles-grant-ibigroup miles-grant-ibigroup added BLOCKERS Blockers exist outside of otp-ui (e.g., backend, service, etc...) and removed BLOCKERS Blockers exist outside of otp-ui (e.g., backend, service, etc...) labels Sep 30, 2024
@daniel-heppner-ibigroup
Copy link
Contributor

Maybe... no icon? idk

@miles-grant-ibigroup
Copy link
Collaborator Author

miles-grant-ibigroup commented Oct 3, 2024

So the snapshots are making it seem like there's some weird stuff going on with TNC legs, but this seems to be a snapshot issue more than an actual issue (our data is funky/OTP1)

@miles-grant-ibigroup miles-grant-ibigroup merged commit 17eb758 into opentripplanner:master Oct 3, 2024
2 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the transfer-leg-support branch October 3, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants