-
Notifications
You must be signed in to change notification settings - Fork 108
Fix: print device pci id correctly #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ok to test |
Can one of the admins verify this patch? |
@amirsojoodi Need to sign the CLA before we can accept PRs (unless you are part of an org. that already signed) https://github.com/openucx/ucc?tab=readme-ov-file#contributing @manjugv Can you DM him the details, please? |
@janjust I am not in an already signed organization. So, sure. I'll sign the CLA, because there might be a few other PRs. |
@amirsojoodi Please sign the individual and send it to UCF. https://github.com/openucx/ucc/blob/master/CONTRIBUTING.md What is your email, so I can send a message? Thanks. |
Should I mail the signed copy or would scanned doc be enough? amir.sojoodi[at]gmail |
766d12a
to
14dcaf7
Compare
@amirsojoodi the reason code-style check is failing is due to commit title. |
@janjust To edit the commit title, I had to amend the commit locally and forced push over the same branch from my fork. Your later commit should be done again. |
What
Very small change in TL/CUDA to print the device from the correct index of
pci_str
buffer.