Skip to content

Fix: print device pci id correctly #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amirsojoodi
Copy link

What

Very small change in TL/CUDA to print the device from the correct index of pci_str buffer.

@Sergei-Lebedev
Copy link
Contributor

ok to test

@swx-jenkins3
Copy link

Can one of the admins verify this patch?

@janjust
Copy link
Collaborator

janjust commented Dec 9, 2024

@amirsojoodi Need to sign the CLA before we can accept PRs (unless you are part of an org. that already signed)

https://github.com/openucx/ucc?tab=readme-ov-file#contributing

@manjugv Can you DM him the details, please?

@amirsojoodi
Copy link
Author

@janjust I am not in an already signed organization. So, sure. I'll sign the CLA, because there might be a few other PRs.

@janjust janjust self-requested a review March 14, 2025 16:40
@manjugv
Copy link
Contributor

manjugv commented Mar 14, 2025

@amirsojoodi Please sign the individual and send it to UCF. https://github.com/openucx/ucc/blob/master/CONTRIBUTING.md

What is your email, so I can send a message? Thanks.

@amirsojoodi
Copy link
Author

@amirsojoodi Please sign the individual and send it to UCF. https://github.com/openucx/ucc/blob/master/CONTRIBUTING.md

What is your email, so I can send a message? Thanks.

Should I mail the signed copy or would scanned doc be enough?

amir.sojoodi[at]gmail

@janjust janjust force-pushed the patch-1 branch 2 times, most recently from 766d12a to 14dcaf7 Compare March 20, 2025 16:23
@janjust
Copy link
Collaborator

janjust commented Mar 20, 2025

@amirsojoodi the reason code-style check is failing is due to commit title.
Should be TL/CUDA: fix pinrt device pci id correctly
Can you check it please

@amirsojoodi
Copy link
Author

@janjust To edit the commit title, I had to amend the commit locally and forced push over the same branch from my fork. Your later commit should be done again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants