CORE: enhance error log in collective init #1104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samnordmann
approved these changes
Apr 1, 2025
ikryukov
suggested changes
Apr 1, 2025
|
bot:retest |
Sergei-Lebedev
force-pushed
the
topic/improve_error_handling_on_init_error
branch
from
64e76c1 to
989cd06
Compare
ikryukov
approved these changes
Apr 8, 2025
janjust
force-pushed
the
topic/improve_error_handling_on_init_error
branch
from
989cd06 to
de16909
Compare
- Improved error logging in `ucc_collective_init` to include detailed collective arguments on failure. - Updated `ucc_tl_ucp_allreduce_knomial_init` to ensure proper task cleanup on initialization failure.
Sergei-Lebedev
force-pushed
the
topic/improve_error_handling_on_init_error
branch
from
de16909 to
bee0585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ucc_collective_initto include detailed collective arguments on failure.ucc_tl_ucp_allreduce_knomial_initto ensure proper task cleanup on initialization failure.