Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCT/CUDA/BASE: Changed log level of cuInit errors. #10528

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

rakhmets
Copy link
Contributor

@rakhmets rakhmets commented Mar 3, 2025

What?

Changed log level of cuInit errors.
Error level is too high for this logging. This code can be called on a system with no CUDA-capable device. Debug message is enough in this case.
Fixes internal issue 4338480

@rakhmets rakhmets requested a review from brminich March 3, 2025 14:59
Copy link
Contributor

@brminich brminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we return back an error print removed in #10492?

@rakhmets
Copy link
Contributor Author

rakhmets commented Mar 3, 2025

shall we return back an error print removed in #10492?

No, this fixed duplicate output.

@brminich
Copy link
Contributor

brminich commented Mar 3, 2025

shall we return back an error print removed in #10492?

No, this fixed duplicate output.

you mean it is already printed by uct_cuda_base_query_md_resources?

@rakhmets
Copy link
Contributor Author

rakhmets commented Mar 3, 2025

shall we return back an error print removed in #10492?

No, this fixed duplicate output.

you mean it is already printed by uct_cuda_base_query_md_resources?

The removed line duplicates the output of the UCT_CUDADRV_FUNC_LOG_ERR macro.

    status = UCT_CUDADRV_FUNC_LOG_ERR(cuDeviceGetCount(&num_devices));
    if (UCS_OK != status) {
-        ucs_error("cuDeviceGetCount() failed: %s", ucs_status_string(status));
        return NULL;
    }

@yosefe yosefe merged commit bf4f479 into openucx:master Mar 4, 2025
151 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants