UCT/API: New api to use mem flags and distance in perf estimate #10546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyastreb
reviewed
Mar 12, 2025
| UCT_PERF_ATTR_FIELD_REMOTE_MEMORY_FLAGS = UCS_BIT(6), | ||
|
|
||
| /** Enable @ref uct_perf_attr_t::distance */ | ||
| UCT_PERF_ATTR_FIELD_DISTANCE = UCS_BIT(7), |
rakhmets
reviewed
Mar 14, 2025
| @@ -1068,7 +1103,7 @@ ucs_status_t uct_ep_query(uct_ep_h ep, uct_ep_attr_t *ep_attr); | |||
| * @return Nonzero if reachable, 0 if not. | |||
| */ | |||
| int uct_iface_is_reachable_v2(uct_iface_h iface, | |||
| const uct_iface_is_reachable_params_t *params); | |||
| uct_iface_is_reachable_params_t *params); | |||
There was a problem hiding this comment.
We need to add unit tests to gtest\uct to test the API. Currently we don't have such tests at all. We only cover this API in gtest\ucp\test_ucp_wireup.cc, gtest\uct\ib\test_ib_pkey.cc. However, this is not enough. We need to test the exact API using different input parameters. I think adding a simple one at least for new fields would be good way to start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Define API to pass memory flags to perf estimation function
Why?
part of #10540