TEAM/UCX: don't use event query with dynamic kernel #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergei-Lebedev
force-pushed
the
topic/stream_check_status
branch
from
5a88ece
to
4506b08
Compare
vspetrov
approved these changes
Jan 18, 2021
| @@ -3,14 +3,14 @@ | |||
|
|
|||
| xccl_cuda_mem_component_t xccl_cuda_mem_component; | |||
|
|
|||
| #define NUM_STREAM_REQUESTS 4 | |||
| #define NUM_STREAM_REQUESTS 128 | |||
There was a problem hiding this comment.
do we need a dynamic parameter for this?
| xccl_status_t st; | ||
| cudaStream_t internal_stream, user_stream; | ||
|
|
||
| XCCL_CUDA_INIT_RESOUCES(); | ||
| st = xccl_cuda_get_free_stream_request(&request); | ||
| if (st != XCCL_OK) { | ||
| fprintf(stderr, "cuda mc: failed to get stream req (%d)\n", st); |
There was a problem hiding this comment.
why fprintf, not a verbose wrapper?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.