Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce delete_dataset method #489

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Introduce delete_dataset method #489

merged 4 commits into from
Sep 4, 2024

Conversation

igor-davidyuk
Copy link
Contributor

@igor-davidyuk igor-davidyuk commented Aug 30, 2024

This PR extends DatasetClients functionality.

Signed-off-by: Igor-Davidyuk <[email protected]>
Signed-off-by: Igor-Davidyuk <[email protected]>
Signed-off-by: Igor-Davidyuk <[email protected]>
@@ -47,6 +50,30 @@ def create_dataset(self, name: str) -> Dataset:
self.project.datasets.append(dataset)
return dataset

def delete_dataset(self, dataset: Dataset) -> None:
"""
Delete provided dataset inside the project.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this would also remove all media and annotations in the dataset, correct? Maybe we should add a warning note about that in the docstring

Copy link
Collaborator

@rajeshgangireddy rajeshgangireddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ljcornel ljcornel merged commit 63a37f4 into main Sep 4, 2024
12 checks passed
@ljcornel ljcornel deleted the idavidyu/dataset-delete branch September 4, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants