Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark model response fields as deprecated in 2.6 instead of removed #528

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Mark model response fields as deprecated in 2.6 instead of removed #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8c5f8a
Mark model response fields as deprecated in 2.6 instead of removed
leoll2 Dec 13, 2024
e478dcd
fix style
leoll2 Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions geti_sdk/data_models/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,12 @@ class BaseModel:
name: str
precision: List[str]
creation_date: str = attr.field(converter=str_to_datetime)
latency: Optional[str] = None # Removed in Geti 2.6
fps_throughput: Optional[float] = None # Removed in Geti 2.6
latency: Optional[str] = None # Deprecated in Geti 2.6
fps_throughput: Optional[float] = None # Deprecated in Geti 2.6
purge_info: Optional[ModelPurgeInfo] = None
size: Optional[int] = None
target_device: Optional[str] = None
target_device_type: Optional[str] = None
target_device: Optional[str] = None # Deprecated in Geti 2.6
target_device_type: Optional[str] = None # Deprecated in Geti 2.6
previous_revision_id: Optional[str] = None
previous_trained_revision_id: Optional[str] = None
performance: Optional[Performance] = None
Expand Down Expand Up @@ -241,8 +241,9 @@ class Model(BaseModel):
"""

architecture: str = attr.field(kw_only=True)
# Removed in Geti 2.6
score_up_to_date: Optional[bool] = attr.field(default=None, kw_only=True)
score_up_to_date: Optional[bool] = attr.field(
default=None, kw_only=True
) # Deprecated in Geti 2.6
optimized_models: List[OptimizedModel] = attr.field(kw_only=True)
# Removed in Geti 2.2
optimization_capabilities: Optional[OptimizationCapabilities] = attr.field(
Expand Down
2 changes: 1 addition & 1 deletion geti_sdk/data_models/model_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class ModelSummary:

name: str
creation_date: str = attr.field(converter=str_to_datetime)
score_up_to_date: Optional[bool] = None # Removed in Geti 2.6
score_up_to_date: Optional[bool] = None # Deprecated in Geti 2.6
purge_info: Optional[ModelPurgeInfo] = None
size: Optional[int] = None
version: Optional[int] = None # 'version' is removed in v1.1
Expand Down
Loading