CVS-154698, Implement windows specific status codes #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atobiszei
approved these changes
Dec 2, 2024
rasapala
reviewed
Dec 10, 2024
src/server.cpp
Outdated
|
|
||
| #ifdef _WIN32 | ||
| WSADATA wsaData; | ||
| if (WSAStartup(MAKEWORD(2, 2), &wsaData) != 0) { |
There was a problem hiding this comment.
I think its not neded here. GRPCServerModule::isPortAvailable.
rasapala
reviewed
Dec 10, 2024
src/server.cpp
Outdated
| } | ||
| SPDLOG_INFO("Shutting down"); | ||
|
|
||
| #ifdef _WIN32 |
There was a problem hiding this comment.
WSACleanup(); to remove ?
rasapala
reviewed
Dec 10, 2024
src/server.cpp
Outdated
| @@ -32,6 +32,7 @@ | |||
| #include <stdlib.h> | |||
|
|
|||
| // TODO: Write windows/linux specific status codes. | |||
There was a problem hiding this comment.
Remove this comment // TODO:
|
reference commit modify the code and CI test is pass |
rasapala
reviewed
Jan 7, 2025
src/server.cpp
Outdated
| } | ||
|
|
||
| // OVMS Start | ||
| int Server::start(int argc, char** argv) { | ||
| #ifdef __linux__ |
There was a problem hiding this comment.
following comment the reduce code has already remove
rasapala
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
Jira ticket : 1 Write windows specific status codes.
Implement windows/linux specific status codes alignment.
Using Winsocket to clean destructor in windows.
🧪 Checklist
``