Pass plugin config to vlm legacy pipeline #3291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkulakowski
changed the title
michalkulakowski
force-pushed
the
mkulakow/pass_plugin_config_to_vlm_legacy_pipeline
branch
from
8b70d75 to
c016d91
Compare
rasapala
approved these changes
May 30, 2025
mzegla
reviewed
May 30, 2025
src/llm/apis/openai_completions.cpp
Outdated
| if (FileSystem::isPathEscaped(url)) { | ||
| std::stringstream ss; | ||
| ss << "Path " << url.c_str() << " escape with .. is forbidden."; | ||
| SPDLOG_LOGGER_ERROR(llm_calculator_logger, ss.str()); |
There was a problem hiding this comment.
Shouldn't we log it on DEBUG level? On error we will see it for log level INFO right? and this is per-request logic
mzegla
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``