Skip to content

Commit

Permalink
Propagate stop token ids from default generation config in LLM pipelines
Browse files Browse the repository at this point in the history
  • Loading branch information
yatarkan committed Jan 28, 2025
1 parent 8a93341 commit 715cdbd
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/cpp/src/llm_pipeline_stateful.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ DecodedResults StatefulLLMPipeline::generate(

auto start_time = std::chrono::steady_clock::now();
GenerationConfig config = (generation_config.has_value()) ? *generation_config : m_generation_config;
// If stop_token_ids were not provided, take value from default m_generation_config
if (config.stop_token_ids.empty())
config.stop_token_ids = m_generation_config.stop_token_ids;
// If eos_token_id was not provided, take value from default m_generation_config
if (config.eos_token_id == -1)
config.set_eos_token_id(m_generation_config.eos_token_id);
Expand Down Expand Up @@ -226,6 +229,9 @@ EncodedResults StatefulLLMPipeline::generate(

GenerationConfig config = (generation_config.has_value()) ? *generation_config : m_generation_config;

// If stop_token_ids were not provided, take value from default m_generation_config
if (config.stop_token_ids.empty())
config.stop_token_ids = m_generation_config.stop_token_ids;
// If eos_token_id was not provided, take value from default m_generation_config
if (config.eos_token_id == -1)
config.set_eos_token_id(m_generation_config.eos_token_id);
Expand Down
6 changes: 6 additions & 0 deletions src/cpp/src/llm_pipeline_static.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -877,6 +877,9 @@ EncodedResults StatefulLLMPipeline::generate(
OPENVINO_ASSERT(batch_size == 1u, "Currently only batch size=1 is supported");

GenerationConfig config = (generation_config.has_value()) ? *generation_config : m_generation_config;
// If stop_token_ids were not provided, take value from default m_generation_config
if (config.stop_token_ids.empty())
config.stop_token_ids = m_generation_config.stop_token_ids;
// If eos_token_id was not provided, take value from default m_generation_config
if (config.eos_token_id == -1)
config.set_eos_token_id(m_generation_config.eos_token_id);
Expand Down Expand Up @@ -1346,6 +1349,9 @@ EncodedResults StatelessLLMPipeline::generate(
}

GenerationConfig config = (generation_config.has_value()) ? *generation_config : m_generation_config;
// If stop_token_ids were not provided, take value from default m_generation_config
if (config.stop_token_ids.empty())
config.stop_token_ids = m_generation_config.stop_token_ids;
// If eos_token_id was not provided, take value from default m_generation_config
if (config.eos_token_id == -1)
config.set_eos_token_id(m_generation_config.eos_token_id);
Expand Down

0 comments on commit 715cdbd

Please sign in to comment.