add missed ignore_eos in generation config #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonbok
approved these changes
Jan 24, 2025
ilya-lavrenov
approved these changes
Jan 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
eaidova
added
port to LTS
ilya-lavrenov
removed
the
port to releases/latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we run benchmarking using optimum we set eos as None to prevent early stopping. Looks like it was missed for genai.
@yeonbok, it is why you see 0 as output for gemma for 32 token prompt.