Improve trim tensor implementation #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -459,6 +469,7 @@ jobs: | |||
| source ./ov/setupvars.sh | |||
| python -m pip install --upgrade-strategy eager -r ./text_generation/causal_lm/cpp/requirements.txt | |||
| python -m pip install ./thirdparty/openvino_tokenizers/[transformers] | |||
| sudo apt-get install libtbb-dev | |||
There was a problem hiding this comment.
maybe we can install TBB only when it's required?
and in cmake we will check:
find_package(TBB COMPONENTS tbb)
if(TBB_FOUND)
target_link_libraries(speculative_decoding_lm PRIVATE TBB::tbb)
endif()
Wovchena
reviewed
May 13, 2024
Wovchena
requested changes
May 13, 2024
ilya-lavrenov
approved these changes
May 13, 2024
|
BTW, it's a temporary change until we merge and release openvinotoolkit/openvino#24359 |
Wovchena
approved these changes
May 13, 2024
|
@sammysun0711 , your trim tensor improvement proposal has been merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: 140109