Fix abi #460
Closed
Fix abi #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…history in KV cache
|
|
||
| import os | ||
| build_dir = os.getenv('GENAI_BUILD_DIR', 'build') | ||
| ov_tokenizers_path = f'{build_dir}/openvino_tokenizers/src/' |
There was a problem hiding this comment.
can we use relative path instead?
E.g. tokenizers, genai and python files are copies to the same directory where we can find tokenizer.so relatively to python files.
There was a problem hiding this comment.
Yes. To do the same in C++ I'd need a path to the current library. Does openvino have have a function for that or an implementation I could copy?
There was a problem hiding this comment.
| @@ -33,7 +33,7 @@ jobs: | |||
| echo "$models" | while read -r model_name model_path; do | |||
| optimum-cli export openvino --trust-remote-code --weight-format fp16 --model "$model_name" "$model_path" | |||
| done | |||
| python -m pytest test_generate_api.py | |||
| GENAI_BUILD_DIR=../../build python -m pytest test_generate_api.py | |||
There was a problem hiding this comment.
tests are example of user code.
users should not know about tokenizers, etc and that some vars need to set, except PYTHONPATH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.