[CORE] OV file utils file_size use std file path #28462

barnasm1 · 2025-01-15T15:26:28Z

Details:

refactor file_size function to accept ov::util::Path / std::filesystem::path. Be backward compatible with previous version.

Tickets:

146659

… paths

…codings

src/common/util/include/openvino/util/file_path.hpp

src/common/util/include/openvino/util/cpp_version.hpp

src/common/util/include/openvino/util/wstring_cast_util.hpp

src/common/util/include/openvino/util/file_path.hpp

src/common/util/include/openvino/util/cpp_version.hpp

src/common/util/include/openvino/util/file_util.hpp

src/core/tests/file_util.cpp

src/common/util/include/openvino/util/file_util.hpp

src/common/util/include/openvino/util/wstring_cast_util.hpp

src/common/util/include/openvino/util/cpp_version.hpp

src/common/util/include/openvino/util/file_path.hpp

refactor to use structured bindings

…codings

src/common/util/CMakeLists.txt

…Lists.txt

… tests

…ests

barnasm1 added 5 commits January 15, 2025 15:18

move wide character string conversions to separate file

887dd2b

refactor

04671c7

refactor file size functions to use ov::util::Path and handle Android…

b334528

… paths

add unit tests for cut_android_path function

c0ec93e

add unit tests for file size functions with various file types and en…

dce5d59

…codings

barnasm1 added the category: Core OpenVINO Core (aka ngraph) label Jan 15, 2025

barnasm1 self-assigned this Jan 15, 2025

barnasm1 requested review from a team as code owners January 15, 2025 15:26

github-actions bot added the category: build OpenVINO cmake script / infra label Jan 15, 2025

barnasm1 and others added 4 commits January 15, 2025 15:40

code format

701cd96

prevent variable redefinition for android

97f2a96

refactor test to use ov::util::Path for Unicode file output

c0345b1

Merge branch 'master' into ov_file_path_util_file_size

66615dc

praasz self-assigned this Jan 16, 2025

praasz added this to the 2025.1 milestone Jan 16, 2025

add Windows-specific includes for wstring_cast_util

a1e8053

ilya-lavrenov reviewed Jan 16, 2025

View reviewed changes

src/common/util/include/openvino/util/file_path.hpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/file_path.hpp Outdated Show resolved Hide resolved

src/common/util/include/openvino/util/cpp_version.hpp Outdated Show resolved Hide resolved

barnasm1 added 2 commits January 16, 2025 12:26

fix comment typo

f34b2d2

refactor cpp_version.hpp and file_path.hpp for compiler version checks

2d071bf

praasz reviewed Jan 16, 2025

View reviewed changes

t-jankowski requested changes Jan 16, 2025

View reviewed changes

barnasm1 added 8 commits January 16, 2025 11:57

refactor WPath function to use lambda syntax, to meet Naming style check

3b2fbae

update copyright year to 2025, fix typos,

eed127e

refactor to use structured bindings

rename wstring_cast_util to wstring_convert_util and update includes

067224b

add Android-specific file size test

22d6712

fix typo in CMakeLists.txt for wstring_convert_util source file path

2e7cf52

deprecate old file_size function and provide alternative usage guidance

e9c2cca

update file size tests to use string literals

71e2206

skip file size tests based on C++ version

c8bdb3b

Simplify file_size function implementation

3227347

mlukasze requested review from praasz, olpipi and ilya-lavrenov January 30, 2025 05:43

barnasm1 and others added 6 commits January 30, 2025 13:32

Update test to avoid filesize discrepancies of std::endl platforms en…

b0f211c

…codings

Merge branch 'master' into ov_file_path_util_file_size

b28d093

Deprecate old file_size function and update tests

b9b1a56

Remove string literal suffixes from file_size test cases

afacbb0

Merge branch 'master' into ov_file_path_util_file_size

99a18fb

Merge branch 'master' into ov_file_path_util_file_size

69b84e1

ilya-lavrenov reviewed Feb 3, 2025

View reviewed changes

src/common/util/CMakeLists.txt Outdated Show resolved Hide resolved

Remove wstring_convert_util.cpp from source files properties in CMake…

1fb30c1

…Lists.txt

github-actions bot removed the category: build OpenVINO cmake script / infra label Feb 3, 2025

barnasm1 added 6 commits February 3, 2025 15:28

fix: update file names in tests to remove underscores

3ed752e

fix: update file_util tests on for unix

7b44026

test: add/fix tests for file size with Unicode character file names

60e848c

fix: add make_path overload for char* in file_util.hpp

073dde2

fix: add char* overload for file_size and simplify make_path usage in…

190dd78

… tests

refactor: remove Android-specific path handling code and associated t…

72978e5

…ests

praasz approved these changes Feb 5, 2025

View reviewed changes

mlukasze requested a review from ilya-lavrenov February 5, 2025 05:47

mlukasze and others added 2 commits February 5, 2025 06:56

Merge branch 'master' into ov_file_path_util_file_size

49422c4

Remove conditional compilation for make_path function in file_util.hpp

4357671

olpipi approved these changes Feb 5, 2025

View reviewed changes

t-jankowski approved these changes Feb 5, 2025

View reviewed changes

barnasm1 added this pull request to the merge queue Feb 5, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025

mlukasze added this pull request to the merge queue Feb 5, 2025

Merged via the queue into openvinotoolkit:master with commit e6be681 Feb 5, 2025
185 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CORE] OV file utils file_size use std file path #28462

[CORE] OV file utils file_size use std file path #28462

barnasm1 commented Jan 15, 2025

[CORE] OV file utils file_size use std file path #28462

[CORE] OV file utils file_size use std file path #28462

Conversation

barnasm1 commented Jan 15, 2025

Details:

Tickets: