Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Use absl inline vector for Shape, Strides #28756

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[WIP] Use absl inline vector for Shape, Strides #28756

wants to merge 5 commits into from

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Jan 31, 2025

Details:

  • PR for test purposes to check usage of inlined_vector in shape, strides

Tickets:

@praasz praasz requested review from a team as code owners January 31, 2025 06:49
@praasz praasz requested review from kblaszczak-intel and mvafin and removed request for a team January 31, 2025 06:49
@praasz praasz requested review from itikhono and removed request for a team January 31, 2025 06:49
@github-actions github-actions bot added category: inference OpenVINO Runtime library - Inference category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: GPU OpenVINO GPU plugin category: CPU OpenVINO CPU plugin category: build OpenVINO cmake script / infra category: Python API OpenVINO Python bindings category: transformations OpenVINO Runtime library - Transformations category: LP transformations OpenVINO Low Precision transformations category: samples OpenVINO Runtime Samples category: IR FE OpenVINO IR v10 / v11 FrontEnd category: TEMPLATE OpenVINO Template plugin category: ONNX FE OpenVINO ONNX FrontEnd category: TF FE OpenVINO TensorFlow FrontEnd category: CPP API OpenVINO CPP API bindings category: PyTorch FE OpenVINO PyTorch Frontend category: TFL FE OpenVINO TensorFlow Lite FrontEnd category: docs_snippets OpenVINO docs snippets (docs/snippets) category: NPU OpenVINO NPU plugin category: JAX FE OpenVINO JAX FrontEnd category: NPUW NPUW plugin labels Jan 31, 2025
@praasz praasz changed the title [POC][WIP] Use absl inline vector for Shape, Strides [WIP] Use absl inline vector for Shape, Strides Jan 31, 2025
@praasz
Remove not used allocator
827a2e6 
Signed-off-by: Raasz, Pawel <[email protected]>
@maxnick maxnick self-assigned this Jan 31, 2025
@praasz praasz added the no_stale Do not mark as stale label Feb 7, 2025
pereanub
pereanub reviewed Feb 21, 2025
View reviewed changes
src/plugins/intel_npu/src/backend/src/zero_tensor.cpp
@@ -59,7 +59,7 @@ void ZeroTensor::update_strides() const {

auto& shape = get_shape();
if (_strides.empty() && !shape.empty()) {
_strides.resize(shape.size());
_strides.resize(shape.size(), {});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the same change to https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_npu/src/common/src/remote_tensor.cpp#L64 please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is draft for testing, so will apply it if solution will give some improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereanub pereanub pereanub left review comments

@kblaszczak-intel kblaszczak-intel Awaiting requested review from kblaszczak-intel kblaszczak-intel is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

@mvafin mvafin Awaiting requested review from mvafin mvafin is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@cavusmustafa cavusmustafa Awaiting requested review from cavusmustafa cavusmustafa is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@ilya-lavrenov ilya-lavrenov Awaiting requested review from ilya-lavrenov ilya-lavrenov is a code owner automatically assigned from openvinotoolkit/openvino-maintainers

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

@maxnick maxnick

Labels
category: build OpenVINO cmake script / infra category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin category: docs_snippets OpenVINO docs snippets (docs/snippets) category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference category: IR FE OpenVINO IR v10 / v11 FrontEnd category: JAX FE OpenVINO JAX FrontEnd category: LP transformations OpenVINO Low Precision transformations category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin category: ONNX FE OpenVINO ONNX FrontEnd category: Python API OpenVINO Python bindings category: PyTorch FE OpenVINO PyTorch Frontend category: samples OpenVINO Runtime Samples category: TEMPLATE OpenVINO Template plugin category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd category: transformations OpenVINO Runtime library - Transformations do_not_merge do_not_review no_stale Do not mark as stale WIP work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praasz @pereanub @maxnick