Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTTI] Move AttributeAdapter<..>'s dtor definitions to cpp #29073

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[RTTI] Move AttributeAdapter<..>'s dtor definitions to cpp #29073

wants to merge 1 commit into from
+66 −27

Conversation

t-jankowski
Copy link
Contributor

Details:

  • Moves AttributeAdapter template class specializations' destructor definitions to outside class definition in new cpp file.

Tickets:

@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings labels Feb 19, 2025
ilya-lavrenov
ilya-lavrenov reviewed Feb 20, 2025
View reviewed changes
src/core/include/openvino/core/attribute_adapter.hpp
@@ -463,5 +463,6 @@ class OPENVINO_API AttributeAdapter<std::set<std::string>> : public DirectValueA
public:
OPENVINO_RTTI("AttributeAdapter<set<string>>");
AttributeAdapter(std::set<std::string>& value) : DirectValueAccessor<std::set<std::string>>(value) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know whether it's possible that we have other AttributeAdapter instances which are not defined in this file?

Or each usage of AttributeAdapter should be doubled here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings do_not_merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-jankowski @ilya-lavrenov