Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Introduce ov::is_type_any_of for chaining ov::is_type calls #29102

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[CPU] Introduce ov::is_type_any_of for chaining ov::is_type calls #29102

wants to merge 5 commits into from
+138 −90

Conversation

aobolensk
Copy link
Contributor

Details:

  • Add ov::is_type_any_of that chains ov::is_type calls for better code readability
  • Reuse new function for applicable cases in CPU plugin

Tickets:

  • N/A

@aobolensk aobolensk requested review from a team as code owners February 21, 2025 11:46
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: CPP API OpenVINO CPP API bindings labels Feb 21, 2025
@github-actions github-actions bot removed the category: CPP API OpenVINO CPP API bindings label Feb 21, 2025
praasz
praasz approved these changes Feb 21, 2025
View reviewed changes
@praasz praasz added this to the 2025.1 milestone Feb 21, 2025
@praasz praasz self-assigned this Feb 21, 2025
t-jankowski
t-jankowski approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@t-jankowski t-jankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for core part

ilya-lavrenov
ilya-lavrenov reviewed Feb 22, 2025
View reviewed changes
src/core/dev_api/openvino/core/type_util.hpp
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov Feb 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a special header for a single function?

I suppose existing openvino/core/type.hpp is a good home for this function

UPD: I saw that it was recommended to put into Dev API, but IMO this function is harmless to be in public API. It's just a useful util

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

@t-jankowski t-jankowski t-jankowski approved these changes

@praasz praasz praasz approved these changes

Assignees

@praasz praasz

Labels
category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
4 participants
@aobolensk @ilya-lavrenov @t-jankowski @praasz