[CPU] Set score_len = 1 if no score_aggregation_window #30682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnick
approved these changes
May 23, 2025
Wovchena
approved these changes
May 23, 2025
| @@ -2410,7 +2410,7 @@ struct MHAHelper { | |||
| int32_t total_kv_len_aligned = 0; | |||
| int32_t total_kv_len = 0; | |||
| for (int32_t i = 0; i < seq_cout; i++) { | |||
| auto score_win_len = score_aggregation_window.ptr<int32_t>()[i]; | |||
| auto score_win_len = score_aggregation_window ? score_aggregation_window.ptr<int32_t>()[i] : 0; | |||
There was a problem hiding this comment.
According to the spec, when score_aggregation_window is unspecified, the value should be 1.
| @@ -2538,7 +2538,7 @@ struct MHAHelper { | |||
| score_block_ptr, | |||
| reinterpret_cast<DATA_TYPE*>(score), | |||
| 1, | |||
| rnd_up(cur_kv_len, _block_size), | |||
| cur_kv_len, | |||
There was a problem hiding this comment.
NOTE for the change: The score_output is aligned to 64 bytes(aka 16 floats), rnd_up(cur_kv_len, _block_size) will align to 32 floats then 2 threads may write to same address and make random wrong result. cvt_add already handles tails so the padding may be removed.
zhangYiIntel
changed the title
maxnick
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
openvinotoolkit:releases/2025/2
with commit May 27, 2025
7751623
215 of 219 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: