[GPU] Fix accuracy issues for sdpa_micro #30698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnyoung-paul
added
category: GPU
yeonbok
reviewed
May 23, 2025
| if (MSK_D2 == 1) { | ||
| // Define mask dimensions for single Query dimension | ||
| uint mask_m = MSK_D1; // num_heads | ||
| uint mask_n = MSK_D3; // sequence_length |
There was a problem hiding this comment.
why num_heads? masks are usually [q, seqlen]..
There was a problem hiding this comment.
Yes, you're right. I fixed codes. please review it again. thanks.
ahnyoung-paul
force-pushed
the
fix_ltx_video_acc
branch
from
c127bc8 to
03475fe
Compare
ahnyoung-paul
changed the title
sshlyapn
reviewed
May 26, 2025
src/plugins/intel_gpu/src/kernel_selector/cl_kernels/sdpa_micro.cl
Outdated
Show resolved
Hide resolved
|
@ahnyoung-paul please add some test case for this scenario |
I'm making unit test for this case. I will update it soon. |
yeonbok
approved these changes
May 27, 2025
sshlyapn
approved these changes
May 27, 2025
ahnyoung-paul
added a commit
to ahnyoung-paul/openvino
that referenced
this pull request
May 28, 2025
### Details: - *Fix attn mask tile loading issue when attn mask shape has single query dimension [batch, num_heads, 1, sequence_length of k]* ### Tickets: - *166691*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: