Skip to content

[core] Suppress coverity issues #32635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 6, 2025
+10 −3
Merged

[core] Suppress coverity issues #32635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f04e961
Suppress coverity issues
t-jankowski Oct 31, 2025
f4eea73
Merge branch 'master' into tj/core/coverity-again
mlukasze Nov 3, 2025
6a03cdd
Merge branch 'master' into tj/core/coverity-again
t-jankowski Nov 5, 2025
724eab4
Merge branch 'master' into tj/core/coverity-again
mlukasze Nov 6, 2025
798db5e
Merge branch 'master' into tj/core/coverity-again
t-jankowski Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core/reference/include/openvino/reference/scaled_dot_product_attention.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ void scaled_dot_product_attention(const T* query,
}

const float default_scale_val = 1.0f / static_cast<float>(std::sqrt(query_shape[query_shape.size() - 1]));
const T scale_val = scale ? *scale : static_cast<T>(default_scale_val);
const T scale_val[1] = {scale ? *scale : static_cast<T>(default_scale_val)};

auto qk_shape = query_shape;
qk_shape[qk_shape.size() - 1] = key_shape[key_shape.size() - 2];
Expand All @@ -109,7 +109,7 @@ void scaled_dot_product_attention(const T* query,
ov::reference::matmul<T>(query, key, qk_data.data(), query_shape, key_shape, qk_shape, false, true);

ov::reference::multiply<T>(qk_data.data(),
&scale_val,
scale_val,
qk_data.data(),
qk_shape,
Shape{1},
Expand Down Expand Up @@ -172,4 +172,4 @@ void scaled_dot_product_attention(const T* query,
ov::reference::matmul<T>(qk_data_softmax.data(), value, output, qk_shape, value_shape, output_shape, false, false);
}
} // namespace reference
} // namespace ov
} // namespace ov
2 changes: 2 additions & 0 deletions src/core/src/any.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ void Any::impl_check() const {

const std::type_info& Any::type_info() const {
impl_check();
// `impl_check' asserts valid deference
// coverity[dereference:FALSE]
Copy link
Contributor

@olpipi olpipi Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need these comments? Is it not enough to close coverity issue as false positive ?

Copy link
Contributor

@praasz praasz Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket closed on Coverity can pop-up again if code changes e.g. this issue will at different line.
If this comment is working it should be always ignored

return _impl->type_info();
}

Expand Down
2 changes: 2 additions & 0 deletions src/core/src/runtime/itensor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ bool ITensor::is_continuous() const {
}

const auto default_last = default_strides.rend();
// It assumed that `default_strides' and `strides' have the same size, thus `default_stride' iterator is valid
// coverity[deref_iterator:SUPPRESS]
return (default_stride == default_last) || (*default_stride < *stride && (get_shape()[0] == 1) &&
std::all_of(default_stride, default_last, cmp::Equal(*default_stride)));
}
Expand Down
3 changes: 3 additions & 0 deletions src/core/xml_util/src/xml_deserialize_util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ std::unordered_set<std::string> deserialize_tensor_names(const std::string_view&
*name_inserter = std::regex_replace(std::string(name_view), escaped_delim, delim);
}
start = pos;
// There's no real case when `pos' equals zero and following test `delim_pos != std::string::npos' protects
// against it.
// coverity[ overflow_const:SUPPRESS]
} else if (auto delim_pos = pos - 1; delim_pos != std::string::npos && tensor_names[delim_pos] == esc_char) {
++pos;
} else {
Expand Down
Loading