-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[onnx] Fix create ONNX DFT op for scalar signal size #32637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
praasz
wants to merge
6
commits into
openvinotoolkit:master
Choose a base branch
from
praasz:bug/fix-onnx-dft-when-signal-size-is-scalar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[onnx] Fix create ONNX DFT op for scalar signal size #32637
praasz
wants to merge
6
commits into
openvinotoolkit:master
from
praasz:bug/fix-onnx-dft-when-signal-size-is-scalar
+95
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raasz, Pawel <[email protected]>
rkazants
reviewed
Oct 31, 2025
rkazants
reviewed
Oct 31, 2025
Signed-off-by: Raasz, Pawel <[email protected]>
…en-signal-size-is-scalar
Signed-off-by: Raasz, Pawel <[email protected]>
Contributor
|
@bumbosiepsak & @rkazants |
rkazants
reviewed
Nov 7, 2025
| name: "value" | ||
| t { | ||
| dims: 1 | ||
| dims: 0 |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be this one is better to leave and add additional one with a scalar?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional test created
rkazants
approved these changes
Nov 7, 2025
…en-signal-size-is-scalar
Signed-off-by: Raasz, Pawel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
dft_lengthas scalar input which is not compatible with OV FFT operators (Must be 1-D). In case of scalar input unsqueeze this input to 1-D.Tickets: