-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[GPU] Enable uint8 weights for oneDNN-based convolution #32650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] Enable uint8 weights for oneDNN-based convolution #32650
Conversation
| one_of(out_dt, {data_types::i32, data_types::f16, data_types::f32, data_types::u8, data_types::i8}); | ||
|
|
||
| if (!f16_conv && !u8s8_conv) | ||
| if (!f16_conv && !int8_conv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a unittest for this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 54638e5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this int8_conv is little confusing, what about 8bit_conv or sth similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm it is good name
|
build_jenkins |
isanghao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
This PR is related #32501 |
|
build_jenkins |
…kit#32650) ### Details: Experimentally enable convolution with uint8 weights to request a oneDNN implementation to improve performance over a reference SIMD8 OpenCL implementation. ### Tickets: - https://jira.devtools.intel.com/browse/CVS-175989
Details:
Experimentally enable convolution with uint8 weights to request a oneDNN implementation to improve performance over a reference SIMD8 OpenCL implementation.
Tickets: