-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Deprecation/Future Warnings in Notebook 211-Speech-to-Text #594
Fix Deprecation/Future Warnings in Notebook 211-Speech-to-Text #594
Conversation
- [`waveplot` is deprecated in favor of `waveshow` since librosa v0.9.](https://librosa.org/doc/latest/changelog.html?highlight=waveplot#v0-8-1) Note that `max_sr` in [`waveplot`](http://librosa.org/doc/0.8.1/generated/librosa.display.waveplot.html?highlight=max_sr#librosa.display.waveplot) is removed. `max_sr` controls how signals are down-sampled if they’re too long. (`waveplot` uses “a downsampled amplitude envelope” instead) - `librosa.filters.mel` in `audio_to_mel` FutureWarning: Pass `sr=16000, n_fft=512` as keyword args. From version 0.10 passing these as positional arguments will result in an error.
`max_points` should be an `int`, not `float`.
Sorry, it's mine. (I checked it on a private repo and manually copy the changes to this repo - the screenshot was right.) |
Hi @YDX-2147483647, thanks for your contribution. It would be great if you can add |
New discovery: librosa v0.8.1 exists in I > pip show librosa
Name: librosa
Version: 0.8.1
……
Requires: audioread, decorator, joblib, numba, numpy, packag
ing, pooch, resampy, scikit-learn, scipy, soundfile
Required-by: ppgan openvino_notebooks/requirements.txt Line 26 in 6e76762
It seems that ppgan only uses librosa to read/write wav. Therefore I'll turn to ppgan and mark this PR as WIP. |
@YDX-2147483647 please add it to requirements and Pipfile anyway |
✓ OK, but maybe tomorrow. |
Hi @YDX-2147483647. Thanks for updating |
Uhh… Thanks for helping me. In fact I had noticed “(and lock it afterward)”, but got stuck at |
Could I leave Reason: As mentioned above, there’s no new requirement at all — we only elevate My difficulty: I can’t My tries(Failures omitted)
It sounds ridiculous that I am fighting against PyTorch environment days and night without using it… But it's truth. |
@YDX-2147483647 ok, we will add librosa in another PR, let's merge your changes in 211 |
Thanks! |
…inotoolkit#594) * Fix deprecation/future warnings in notebook 211 - [`waveplot` is deprecated in favor of `waveshow` since librosa v0.9.](https://librosa.org/doc/latest/changelog.html?highlight=waveplot#v0-8-1) Note that `max_sr` in [`waveplot`](http://librosa.org/doc/0.8.1/generated/librosa.display.waveplot.html?highlight=max_sr#librosa.display.waveplot) is removed. `max_sr` controls how signals are down-sampled if they’re too long. (`waveplot` uses “a downsampled amplitude envelope” instead) - `librosa.filters.mel` in `audio_to_mel` FutureWarning: Pass `sr=16000, n_fft=512` as keyword args. From version 0.10 passing these as positional arguments will result in an error. * Fix `waveshow` Speech to text notebook 211 `max_points` should be an `int`, not `float`. * add librosa to requirements * Update .docker/Pipfile * Update requirements.txt Co-authored-by: Adrian Boguszewski <[email protected]>
waveplot
is deprecated in favor ofwaveshow
since librosa v0.8.1, and removed in v0.9.0.This was mentioned in the original pull request in Dec. 2021, but not fixed (for unknown reason).
Note that
max_sr
inwaveplot
is removed inwaveshow
.max_sr
controls how signals are down-sampled if they’re too long. (waveshow
uses “a downsampled amplitude envelope” instead)librosa.filters.mel
inaudio_to_mel
FutureWarning: Pass
sr=16000, n_fft=512
as keyword args. From version 0.10 passing these as positional arguments will result in an error.Question
The original pull requeset did NOT add librosa (the audio analysis package used here) into
requirements.txt
or.docker/Pipfile
. Is it on purpose? Should I tell how to install it in the notebook?